Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Badge api #357

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

add Badge api #357

wants to merge 9 commits into from

Conversation

jhk482001
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jan 17, 2025

Coverage Status

coverage: 81.013% (-1.7%) from 82.699%
when pulling ca9c1ee on badge-api
into 49199d5 on master.

Copy link
Member

@nonumpa nonumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest squashing or removing duplicate commit messages.

This will make it easier for us to review the changes by commit and trace the history more effectively in the future.

docker-compose.yml Show resolved Hide resolved
mise.toml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need to add config file for your dev environment but not for other team members, consider putting it a global gitignore so that the config file doesn't go into the repository. Please remove this file from the pull request.

@jhk482001
Copy link
Collaborator Author

  1. clean commit - done
  2. rollback docker-compose.yml change
  3. rebase master branch
    Please help to review again @MrOrz @nonumpa

@MrOrz MrOrz requested review from MrOrz and nonumpa January 24, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants